Replace lodash.merge with deepmerge package #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tizmagik
requested changes
Dec 23, 2017
package.json
Outdated
| "name": "react-tracking", | ||
| "version": "5.1.0", | ||
| "name": "@dortzur/react-tracking", | ||
| "version": "5.2.0", |
There was a problem hiding this comment.
Revert these two lines please. I will update the version for next release.
|
done! thanks! |
tizmagik
requested changes
Dec 24, 2017
package-lock.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "react-tracking", | |||
| "name": "@dortzur/react-tracking", | |||
There was a problem hiding this comment.
Can you revert this as well please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing lodash.merge with the deepmerge package significantly reduces bundle size.
https://bundlephobia.com/[email protected] (6.3kb gzipped)
https://bundlephobia.com/result?p=@dortzur/[email protected] (2.7kb gzipped)
Thanks for open sourcing this package by the way.