Clone and modify data sets of all kind #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherRabotin
deleted the
200-clone-and-modify-data-sets-of-all-kind
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows in-place modification, renaming, removal, and partial removal of dataset entries from ID or name.
Closes #200
Architectural Changes
DataSetT, i.e. the entries to aDataSet, must now implementDefault. This is requires so we can "zero out" the underlying bytes that represent the data to be removed.New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
Test renaming, removing, accessibility of the renamed and removed data, using both ID and name.
Documentation
This PR does not primarily deal with documentation changes.