-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify and truncate DAF files #243
Merged
ChristopherRabotin
merged 15 commits into
master
from
176-modify-and-truncate-daf-files
May 22, 2024
Merged
Modify and truncate DAF files #243
ChristopherRabotin
merged 15 commits into
master
from
176-modify-and-truncate-daf-files
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not very user friendly, but it works
This will cause issues when truncating the actual data
2 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, looks ok, could use a clean up of the io_imports in mut_daf (that macro isn't needed but it doesn't hurt per se).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Architectural Changes
Most of the
DAF
functionality has been moved to aGenericDAF<W>
, whereW
is eitherBytes
orBytesMut
(of course, only the latter enables modification of the underlying bytes).New Features
name record
)Improvements
No change
Bug Fixes
No change
Testing and validation
Documentation
This PR does not primarily deal with documentation changes.