Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spk_ezr function to Almanac to closesly match SPICE's spkezr function + various minor fixes #313

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

ChristopherRabotin
Copy link
Member

@ChristopherRabotin ChristopherRabotin commented Sep 7, 2024

Summary

The crux of this issue was not an ANISE bug, but in fact it was an issue with the way I was calling transform in the test. I've fixed this by correcting the observation frame and by adding an spkezr function.

Fix #130.

Also fix #284 by adding the proper display of the file record errors.

Also fix #302 -- #302 (comment)

Architectural Changes

No change

New Features

No change

Improvements

No change

Bug Fixes

No change

Testing and validation

Documentation

This PR does not primarily deal with documentation changes.

@ChristopherRabotin ChristopherRabotin changed the title Add spkezr function to Almanac to closesly match SPICE's implementation Add spk_ezr function to Almanac to closesly match SPICE's spkezr function + various minor fixes Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 40.54054% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.44%. Comparing base (a63436f) to head (c9091c6).

Files with missing lines Patch % Lines
anise/src/almanac/transform.rs 0.00% 20 Missing ⚠️
anise/src/naif/daf/daf.rs 93.75% 1 Missing ⚠️
anise/src/naif/pck/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #313      +/-   ##
==========================================
- Coverage   80.53%   80.44%   -0.09%     
==========================================
  Files          76       76              
  Lines        9754     9748       -6     
==========================================
- Hits         7855     7842      -13     
- Misses       1899     1906       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 0a2b594 into master Sep 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant