Fixing line of sight computation + SPICE validation of penumbra calculator #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Must now update/rewrite the LOS computation since that's the point of the ticket and it's obviously wrong
…ranslating if the original and destination frames don't match This affects the computation of the line of sight, working on a validation of this algorithm.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 80.44% 80.55% +0.10%
==========================================
Files 76 77 +1
Lines 9748 10161 +413
==========================================
+ Hits 7842 8185 +343
- Misses 1906 1976 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use longitude_360_deg for previous behavior
The issue had been fixed in a prior commit for 0.4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
transform_tofunction to translate in J2000 frame if the original and observer frames don't have the same rotation. This changes the line of sight calculations. Currently working on validation of the line of sight with an external tool.Architectural Changes
No change
New Features
No change
Improvements
No change
Bug Fixes
No change
Testing and validation
Documentation
This PR does not primarily deal with documentation changes.