Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move logger to within window #334

Merged
merged 5 commits into from
Oct 13, 2024
Merged

Move logger to within window #334

merged 5 commits into from
Oct 13, 2024

Conversation

ChristopherRabotin
Copy link
Member

Summary

Closes #327 .

Architectural Changes

No change

New Features

No change

Improvements

No change

Bug Fixes

No change

Testing and validation

No change

Documentation

This PR does not primarily deal with documentation changes.

@ChristopherRabotin
Copy link
Member Author

I tried the full screen, it's terrible. Revert that. Try to make the open button in the middle or as a window thing.

@ChristopherRabotin
Copy link
Member Author

ChristopherRabotin commented Oct 9, 2024

@ChristopherRabotin ChristopherRabotin changed the title Move logger to within window and switch to egui light theme Move logger to within window Oct 10, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (2f2ebb7) to head (232b0b1).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #334      +/-   ##
==========================================
+ Coverage   80.55%   80.58%   +0.03%     
==========================================
  Files          77       77              
  Lines       10161    10164       +3     
==========================================
+ Hits         8185     8191       +6     
+ Misses       1976     1973       -3     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristopherRabotin ChristopherRabotin merged commit 8345fe5 into master Oct 13, 2024
22 checks passed
@ChristopherRabotin ChristopherRabotin deleted the gh-327-gui-update branch October 13, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed logger in GUI
1 participant