Release/r2018.06.15 (#191) #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow ptr in inline structs * inline pointer_to_struce mode: update comments. return error on pointer not to struct * fix(dbtest): Use os.Kill on windows instead of Interrupt 🐛 I've added a use for os.Kill, instead of os.Interrupt signal, when using Windows. I'm current developing my project on Windows, and using DBServer.Stop() was resulting in: "timeout waiting for mongod process to die". After investigating, I've discovered that os.Interrupt isn't implemented on Windows, and it seems golang has Frozen this issue due to age (2013). They instruct to use os.Kill instead. Using this, the DBServer on my project works with no problem. * Respect nil slices, maps in bson encoder (#147) * socket: only send client metadata once per socket (#105) Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Merge Development (#111) * Brings in a patch on having flusher not suppress errors. (#81) go-mgo#360 * Fallback to JSON tags when BSON tag isn't present (#91) * Fallback to JSON tags when BSON tag isn't present Cleanup. * Add test to demonstrate tagging fallback. - Test coverage for tagging test. * socket: only send client metadata once per socket Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Cluster abended test 254 (#100) * Add a test that mongo Server gets their abended reset as necessary. See https://github.com/go-mgo/mgo/issues/254 and https://github.com/go-mgo/mgo/pull/255/files * Include the patch from Issue 255. This brings in a test which fails without the patch, and passes with the patch. Still to be tested, manual tcpkill of a socket. * changeStream support (#97) Add $changeStream support * readme: credit @peterdeka and @steve-gray (#110) * Hotfix #120 (#136) * cluster: fix deadlock in cluster synchronisation (#120) For a impressively thorough breakdown of the problem, see: #120 (comment) Huge thanks to @dvic and @KJTsanaktsidis for the report and fix. * readme: credit @dvic and @KJTsanaktsidis * added support for marshalling/unmarshalling maps with non-string keys * refactor method receiver * added support for json-compatible support for slices and maps Marshal() func: nil slice or map converts to nil, not empty (initialized with len=0) * fix IsNil on slices and maps format * added godoc * fix sasl empty payload * fix scram-sha-1 auth * revert fix sasl empty payload * Separate read/write network timeouts (#161) * socket: separate read/write network timeouts Splits DialInfo.Timeout (defaults to 60s when using mgo.Dial()) into ReadTimeout and WriteTimeout to address #160. Read/write timeout defaults to DialInfo.Timeout to preserve existing behaviour. * cluster: remove AcquireSocket Only used by tests, replaced by the pool-aware acquire socket functions: * AcquireSocketWithPoolTimeout * AcquireSocketWithBlocking * cluster: use configured timeouts for cluster operations * `mongoCluster.syncServer()` no longer uses hard-coded 5 seconds * `mongoCluster.isMaster()` no longer uses hard-coded 10 seconds * tests: use DialInfo for internal timeouts * server: fix fantastic serverTags nil slice bug When unmarshalling serverTags, it is now an empty slice, instead of a nil slice. `len(thing) == 0` works all the time, regardless. * cluster: remove unused duplicate pool config * session: avoid calculating default values in hot path Changes `DialWithInfo` to handle setting default values by setting the relevant `DialInfo` field, rather than calling the respective methods in the hot path for: * `PoolLimit` * `ReadTimeout` * `WriteTimeout` * session: remove unused consts * session: update docs * add URI options: "w", "j", "wtimeoutMS" (#162) * add URI options: "w", "j", "wtimeoutMS" * change "w" to "j" * Add Collation support for calling Count() on a Query (#166) * Expand documentation for *Iter.Next (#163) The documentation now explains the difference between calling Err and Close after Next returns false. The example code has been expanded to include checking for timeout. * add NewMongoTimestamp() and MongoTimestamp.Time(),Counter() (#171) code is inspired by go-mgo#202 * MGO-156 Avoid iter.Next deadlock on dead sockets (#182) * Allow passing slice pointer as an interface pointer to Iter.All (#181) * socket: only send client metadata once per socket (#105) Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Merge Development (#111) * Brings in a patch on having flusher not suppress errors. (#81) go-mgo#360 * Fallback to JSON tags when BSON tag isn't present (#91) * Fallback to JSON tags when BSON tag isn't present Cleanup. * Add test to demonstrate tagging fallback. - Test coverage for tagging test. * socket: only send client metadata once per socket Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Cluster abended test 254 (#100) * Add a test that mongo Server gets their abended reset as necessary. See https://github.com/go-mgo/mgo/issues/254 and https://github.com/go-mgo/mgo/pull/255/files * Include the patch from Issue 255. This brings in a test which fails without the patch, and passes with the patch. Still to be tested, manual tcpkill of a socket. * changeStream support (#97) Add $changeStream support * readme: credit @peterdeka and @steve-gray (#110) * Hotfix #120 (#136) * cluster: fix deadlock in cluster synchronisation (#120) For a impressively thorough breakdown of the problem, see: #120 (comment) Huge thanks to @dvic and @KJTsanaktsidis for the report and fix. * readme: credit @dvic and @KJTsanaktsidis * Allow passing slice pointer as an interface pointer to Iter.All * Reverted to original error message, added test case for interface{} ptr * Contributing:findAndModify support writeConcern (#185) * socket: only send client metadata once per socket (#105) Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Merge Development (#111) * Brings in a patch on having flusher not suppress errors. (#81) go-mgo#360 * Fallback to JSON tags when BSON tag isn't present (#91) * Fallback to JSON tags when BSON tag isn't present Cleanup. * Add test to demonstrate tagging fallback. - Test coverage for tagging test. * socket: only send client metadata once per socket Periodic cluster synchronisation calls isMaster() which currently resends the "client" metadata every call - the spec specifies: isMaster commands issued after the initial connection handshake MUST NOT contain handshake arguments https://github.com/mongodb/specifications/blob/master/source/mongodb-handshake/handshake.rst#connection-handshake This hotfix prevents subsequent isMaster calls from sending the client metadata again - fixes #101 and fixes #103. Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial issue, opening tickets, and having the problem debugged with a PoC fix before I even woke up. * Cluster abended test 254 (#100) * Add a test that mongo Server gets their abended reset as necessary. See https://github.com/go-mgo/mgo/issues/254 and https://github.com/go-mgo/mgo/pull/255/files * Include the patch from Issue 255. This brings in a test which fails without the patch, and passes with the patch. Still to be tested, manual tcpkill of a socket. * changeStream support (#97) Add $changeStream support * readme: credit @peterdeka and @steve-gray (#110) * Hotfix #120 (#136) * cluster: fix deadlock in cluster synchronisation (#120) For a impressively thorough breakdown of the problem, see: #120 (comment) Huge thanks to @dvic and @KJTsanaktsidis for the report and fix. * readme: credit @dvic and @KJTsanaktsidis * findAndModify support writeConcern * fix * readme: credit everyone (#187) * @cedric-cordenier * @DaytonG * @ddspog * @gedge * @jefferickson * @larrycinnabar * @Mei-Zhao * @roobre * revert: MGO-156 Avoid iter.Next deadlock on dead sockets (#182) (#188) This reverts commit 7253b2b. * Add support for ssl dial string (#184) * Add support for ssl dial string * Ensure we dont override user settings * update examples * update ssl value parsing * PingSsl test * skip test requiring system certificates * readme: credit @tbruyelle (#190)
Test against Mongo minor releases updates as of Aug 2018
Revert "Test against Mongo minor releases updates as of Aug 2018"
…ted-versions Issue template and MongoDB supported versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow ptr in inline structs
inline pointer_to_struce mode: update comments. return error on pointer not to struct
fix(dbtest): Use os.Kill on windows instead of Interrupt 🐛
I've added a use for os.Kill, instead of os.Interrupt signal, when using
Windows. I'm current developing my project on Windows, and using
DBServer.Stop() was resulting in: "timeout waiting for mongod process to
die". After investigating, I've discovered that os.Interrupt isn't
implemented on Windows, and it seems golang has Frozen this issue due to
age (2013). They instruct to use os.Kill instead. Using this, the
DBServer on my project works with no problem.
Respect nil slices, maps in bson encoder (Respect nil slices, maps in bson encoder globalsign/mgo#147)
socket: only send client metadata once per socket (socket: only send client metadata once per socket globalsign/mgo#105)
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Merge Development (Merge Development globalsign/mgo#111)
Brings in a patch on having flusher not suppress errors. (Brings in a patch on having flusher not suppress errors. globalsign/mgo#81)
go-mgo#360
Fallback to JSON tags when BSON tag isn't present (Fallback to JSON tags when BSON tag isn't present globalsign/mgo#91)
Fallback to JSON tags when BSON tag isn't present
Cleanup.
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Cluster abended test 254 (Cluster abended test 254 globalsign/mgo#100)
Add a test that mongo Server gets their abended reset as necessary.
See https://github.com/go-mgo/mgo/issues/254 and
https://github.com/go-mgo/mgo/pull/255/files
This brings in a test which fails without the patch, and passes with the
patch. Still to be tested, manual tcpkill of a socket.
Add $changeStream support
readme: credit @peterdeka and @steve-gray (readme: credit @peterdeka and @steve-gray globalsign/mgo#110)
Hotfix test killed after 10min on travis with docker mongo globalsign/mgo#120 (Hotfix #120 globalsign/mgo#136)
cluster: fix deadlock in cluster synchronisation (test killed after 10min on travis with docker mongo globalsign/mgo#120)
For a impressively thorough breakdown of the problem, see:
globalsign#120 (comment)
Huge thanks to @dvic and @KJTsanaktsidis for the report and fix.
readme: credit @dvic and @KJTsanaktsidis
added support for marshalling/unmarshalling maps with non-string keys
refactor method receiver
added support for json-compatible support for slices and maps Marshal() func: nil slice or map converts to nil, not empty (initialized with len=0)
fix IsNil on slices and maps
format
added godoc
fix sasl empty payload
fix scram-sha-1 auth
revert fix sasl empty payload
Separate read/write network timeouts (Separate read/write network timeouts globalsign/mgo#161)
socket: separate read/write network timeouts
Splits DialInfo.Timeout (defaults to 60s when using mgo.Dial()) into ReadTimeout
and WriteTimeout to address globalsign#160. Read/write timeout defaults to
DialInfo.Timeout to preserve existing behaviour.
Only used by tests, replaced by the pool-aware acquire socket functions:
* AcquireSocketWithPoolTimeout
* AcquireSocketWithBlocking
cluster: use configured timeouts for cluster operations
mongoCluster.syncServer()no longer uses hard-coded 5 secondsmongoCluster.isMaster()no longer uses hard-coded 10 secondstests: use DialInfo for internal timeouts
server: fix fantastic serverTags nil slice bug
When unmarshalling serverTags, it is now an empty slice, instead of a nil slice.
len(thing) == 0works all the time, regardless.cluster: remove unused duplicate pool config
session: avoid calculating default values in hot path
Changes
DialWithInfoto handle setting default values by setting the relevantDialInfofield, rather than calling the respective methods in the hot path for:session: remove unused consts
session: update docs
add URI options: "w", "j", "wtimeoutMS" (add URI options: "w", "j", "wtimeoutMS" globalsign/mgo#162)
add URI options: "w", "j", "wtimeoutMS"
change "w" to "j"
Add Collation support for calling Count() on a Query (Add Collation support for calling Count() on a Query globalsign/mgo#166)
Expand documentation for *Iter.Next (Expand docs for *Iter.Next globalsign/mgo#163)
The documentation now explains the difference between calling Err and
Close after Next returns false.
The example code has been expanded to include checking for timeout.
code is inspired by go-mgo#202
MGO-156 Avoid iter.Next deadlock on dead sockets (pick: MGO-156 Avoid iter.Next deadlock on dead sockets globalsign/mgo#182)
Allow passing slice pointer as an interface pointer to Iter.All (Allow passing slice pointer as an interface pointer to Iter.All globalsign/mgo#181)
socket: only send client metadata once per socket (socket: only send client metadata once per socket globalsign/mgo#105)
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Merge Development (Merge Development globalsign/mgo#111)
Brings in a patch on having flusher not suppress errors. (Brings in a patch on having flusher not suppress errors. globalsign/mgo#81)
go-mgo#360
Fallback to JSON tags when BSON tag isn't present (Fallback to JSON tags when BSON tag isn't present globalsign/mgo#91)
Fallback to JSON tags when BSON tag isn't present
Cleanup.
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Cluster abended test 254 (Cluster abended test 254 globalsign/mgo#100)
Add a test that mongo Server gets their abended reset as necessary.
See https://github.com/go-mgo/mgo/issues/254 and
https://github.com/go-mgo/mgo/pull/255/files
This brings in a test which fails without the patch, and passes with the
patch. Still to be tested, manual tcpkill of a socket.
Add $changeStream support
readme: credit @peterdeka and @steve-gray (readme: credit @peterdeka and @steve-gray globalsign/mgo#110)
Hotfix test killed after 10min on travis with docker mongo globalsign/mgo#120 (Hotfix #120 globalsign/mgo#136)
cluster: fix deadlock in cluster synchronisation (test killed after 10min on travis with docker mongo globalsign/mgo#120)
For a impressively thorough breakdown of the problem, see:
globalsign#120 (comment)
Huge thanks to @dvic and @KJTsanaktsidis for the report and fix.
readme: credit @dvic and @KJTsanaktsidis
Allow passing slice pointer as an interface pointer to Iter.All
Reverted to original error message, added test case for interface{} ptr
Contributing:findAndModify support writeConcern (Contributing:findAndModify support writeConcern globalsign/mgo#185)
socket: only send client metadata once per socket (socket: only send client metadata once per socket globalsign/mgo#105)
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Merge Development (Merge Development globalsign/mgo#111)
Brings in a patch on having flusher not suppress errors. (Brings in a patch on having flusher not suppress errors. globalsign/mgo#81)
go-mgo#360
Fallback to JSON tags when BSON tag isn't present (Fallback to JSON tags when BSON tag isn't present globalsign/mgo#91)
Fallback to JSON tags when BSON tag isn't present
Cleanup.
Periodic cluster synchronisation calls isMaster() which currently resends the
"client" metadata every call - the spec specifies:
This hotfix prevents subsequent isMaster calls from sending the client metadata
again - fixes globalsign#101 and fixes globalsign#103.
Thanks to @changwoo-nam @qhenkart @canthefason @jyoon17 for spotting the initial
issue, opening tickets, and having the problem debugged with a PoC fix before I
even woke up.
Cluster abended test 254 (Cluster abended test 254 globalsign/mgo#100)
Add a test that mongo Server gets their abended reset as necessary.
See https://github.com/go-mgo/mgo/issues/254 and
https://github.com/go-mgo/mgo/pull/255/files
This brings in a test which fails without the patch, and passes with the
patch. Still to be tested, manual tcpkill of a socket.
Add $changeStream support
readme: credit @peterdeka and @steve-gray (readme: credit @peterdeka and @steve-gray globalsign/mgo#110)
Hotfix test killed after 10min on travis with docker mongo globalsign/mgo#120 (Hotfix #120 globalsign/mgo#136)
cluster: fix deadlock in cluster synchronisation (test killed after 10min on travis with docker mongo globalsign/mgo#120)
For a impressively thorough breakdown of the problem, see:
globalsign#120 (comment)
Huge thanks to @dvic and @KJTsanaktsidis for the report and fix.
readme: credit @dvic and @KJTsanaktsidis
findAndModify support writeConcern
fix
readme: credit everyone (readme: credit everyone globalsign/mgo#187)
@cedric-cordenier
@DaytonG
@ddspog
@gedge
@jefferickson
@larrycinnabar
@Mei-Zhao
@roobre
revert: MGO-156 Avoid iter.Next deadlock on dead sockets (pick: MGO-156 Avoid iter.Next deadlock on dead sockets globalsign/mgo#182) (revert: MGO-156 Avoid iter.Next deadlock on dead sockets (#182) globalsign/mgo#188)
This reverts commit 7253b2b.
Add support for ssl dial string (Add support for ssl dial string globalsign/mgo#184)
Add support for ssl dial string
Ensure we dont override user settings
update examples
update ssl value parsing
PingSsl test
skip test requiring system certificates
readme: credit @tbruyelle (readme: credit @tbruyelle globalsign/mgo#190)