Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: improve Mina Signer docs #544

Open
barriebyron opened this issue Jul 28, 2023 · 1 comment · May be fixed by #590
Open

DX: improve Mina Signer docs #544

barriebyron opened this issue Jul 28, 2023 · 1 comment · May be fixed by #590
Assignees
Labels
docs Improvements or additions to documentation feedback zkApps Focused zkApps content

Comments

@barriebyron
Copy link
Contributor

barriebyron commented Jul 28, 2023

zkIgnite Cohort 1 Technical Feedback identified an issue that has been only lightly fixed and requires more content.
O(1) Copy of [Open] Cohort 1 Technical Feedback
SEE ROW 2
The mina-signer package for key pair generation and transaction signing
related to (duplicate of?) https://app.zenhub.com/workspaces/zkapps-product-eng-6130fedb3b0fc600123d8796/issues/gh/o1-labs/docs2/257

Let's answer these questions:

  • What is Mina Signer and how is it used?
  • What Mina Signer content do devs need to succeed?
  • Can we provide example code?

https://docs.minaprotocol.com/node-operators/mina-signer supersedes the deprecated Client SDK doc but is incomplete and can be more helpful

See o1-labs/o1js#1026 for devs to use mina-signer to create Nullifiers in production, since it does not leak the private key of the user.

#443 introduced a quick fix:

@barriebyron barriebyron added the docs Improvements or additions to documentation label Jul 28, 2023
@barriebyron barriebyron added feedback zkApps Focused zkApps content labels Aug 14, 2023
@barriebyron
Copy link
Contributor Author

potential for an explainer doc in the zkApp dev docs section
how to use Mina Signer with zkApp

@MartinMinkov MartinMinkov self-assigned this Sep 7, 2023
@MartinMinkov MartinMinkov linked a pull request Sep 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation feedback zkApps Focused zkApps content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants