-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace ClientSDK with Mina Signer in client-sdk.mdx #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MartinMinkov do we need a redirect here? and if so, how do redirects work? |
Yes, good catch! You can add one by adding the following code in our {
from: '/node-operators/client-sdk',
to: '/node-operators/mina-signer',
}, |
MartinMinkov
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started to fix a broken link because the Client SDK is now deprecated and is superseded by MinaSigner
So then the scope expanded to address quality opportunities(including case, consistency, style, capitalization, SNARK worker instances - see the Docs Style Guide for guidance, especially the Word List
Mina friends! Please review updates to ensure I didn't inadvertently introduce technical inaccuracies
Questions? Please ask
As always, Mina docs contributions are most welcome (and much needed)