-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base64 Encoding/Decoding and Enhanced String Handling for Bytes #1659
Conversation
…sing the JS Buffer class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shigoto-dev19! This is an incredible addition to o1js.
I'll review in detail later but have some quick feedback: You can't remove methods like toHex()
and fromHex()
because this is a breaking change and would move o1js to version 2.0 according to semver, which we don't want.
This reverts commit db97068.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed it, have a few more comments, looks great overall
note that the tests are just failing because you changed the |
Thank you for the review! I'll address the comments and update the branch :) |
This reverts commit 9baf3a1.
Description
All changes revolve around the provable Bytes class.
Changes
base64Encode
andbase64Decode
methods.Notes
o1js-base64
repo README.