Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for publishing on NPM. #1762

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix for publishing on NPM. #1762

merged 1 commit into from
Jul 17, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Jul 17, 2024

@shimkiv shimkiv added the bug Something isn't working label Jul 17, 2024
@shimkiv shimkiv self-assigned this Jul 17, 2024
ymekuria
ymekuria approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shimkiv shimkiv merged commit 885b50e into main Jul 17, 2024
15 checks passed
@shimkiv shimkiv deleted the hot-fix/npm-publish branch July 17, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymekuria ymekuria ymekuria approved these changes

@MartinMinkov MartinMinkov Awaiting requested review from MartinMinkov

@mitschabaude mitschabaude Awaiting requested review from mitschabaude

@Trivo25 Trivo25 Awaiting requested review from Trivo25

Assignees

@shimkiv shimkiv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate Nightly tests failures (SvelteKit, Next.js projects) caused by inability to load o1js.
2 participants
@shimkiv @ymekuria