-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge CI fixes from main to v2. #1780
Conversation
shimkiv
commented
Jul 29, 2024
- Refactor GitHub Actions Workflows for Improved CI/CD Performance #1760
- Disable LFS during submodules fetching. #1772
Is this a proper merge? I don't see any commits |
Yea, CI is happy now. I picked up changed files instead of concrete commits this time. |
In general it would be better to do merges because whoever does the merge main -> v2 next time might have to deal with fake "conflicts" introduced by this PR which is making the same changes as on main but in different commits |
Ok, since this PR already has different commit then I'll need to close this one and create one with only commits from |
It's fine! Just wanted to nudge you towards using |
runs-on: ubuntu-latest | ||
outputs: | ||
test_count: ${{ steps.count_tests.outputs.test_count }} | ||
chunk_count: 8 # This is hardcoded to 8, but it can be changed to any number. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this number do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amount of chunks unit tests split into I believe.
Thanks, yet I'll do it this time too. v2 -> main already has a good bunch of conflicts, and I don't want to cause more pain :) |
#1781 |