Merge main into V2 to fix CI #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish Veridise audit
Update mina compatible to contain poseidon vectors fix
attempt CI fix
…fix-vectors-attempt2 [attempt2] Update mina version to contain poseidon test vector fix
Trivo25
commented
Sep 26, 2024
| @@ -35,7 +35,9 @@ it('pickles rule creation', async () => { | |||
| // a rule that verifies a proof conditionally, and returns the proof's input as output | |||
| function main(proof: EmptyProof, shouldVerify: Bool) { | |||
| proof.verifyIf(shouldVerify); | |||
| return proof.publicInput; | |||
| return { | |||
There was a problem hiding this comment.
left over fix from the auxiliary output PR which wasn't caught in CI
querolita
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly to make sure the CI fixes also land in V2