Fix: this === undefined in Struct static methods #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitschabaude
commented
Jan 12, 2023
| @@ -1268,16 +1268,8 @@ Use the optional \`maxTransactionsWithActions\` argument to increase this number | |||
| // also, for each action length, compute the new state and then pick the actual one | |||
| let newStates = actionss.map((actions) => { | |||
| // we generate a new witness for the state so that this doesn't break if `apply` modifies the state | |||
| let newState = Circuit.witness(stateType, () => { | |||
| // TODO: why doesn't this work without the toConstant mapping? | |||
| let { toFields, fromFields, toAuxiliary } = stateType; | |||
There was a problem hiding this comment.
the problem here was that pulling those static members out of the class is not compatible with using this in those static methods. js rookie mistake
There was a problem hiding this comment.
and it turns out wee don't need that toConstant logic anymore, at all, because Circuit.witness does that under the hood anyway
Trivo25
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug reported by community member