Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to arkworks 0.4.2 (mina compatible / p-s develop) #2474

Merged
merged 17 commits into from
Sep 16, 2024

Conversation

volhovm
Copy link
Member

@volhovm volhovm commented Aug 16, 2024

Rebasing the epic PR now on top of the most recent proof-system's develop which maps to mina's compatible.

@dannywillems
Copy link
Member

Oh boy 😨

@volhovm volhovm force-pushed the volhovm/arkworks042-compatible branch 2 times, most recently from 5d7c665 to f968131 Compare August 27, 2024 11:24
@volhovm volhovm force-pushed the volhovm/arkworks042-compatible branch from f968131 to 6866340 Compare September 11, 2024 12:14
@volhovm volhovm marked this pull request as ready for review September 11, 2024 12:16
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo comment. Not approving because of circuit-construction.

curves/src/pasta/curves/tests.rs Show resolved Hide resolved
Cargo.lock Show resolved Hide resolved
Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volhovm volhovm merged commit a03e92e into develop Sep 16, 2024
5 checks passed
@volhovm volhovm deleted the volhovm/arkworks042-compatible branch September 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants