Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o1vm/pickles: introduce the computation of the quotient polynomial #2652

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

@dannywillems dannywillems commented Oct 3, 2024

TODO:

  • absorb the commitments
  • add in the opening proof

Note that this will break the e2e tests because selectors polynomials are not defined correctly at the moment.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.

Project coverage is 72.57%. Comparing base (f9781af) to head (96d42c1).

Files with missing lines Patch % Lines
o1vm/src/pickles/prover.rs 0.00% 43 Missing ⚠️
o1vm/src/pickles/main.rs 0.00% 3 Missing ⚠️
o1vm/src/pickles/column_env.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           o1vm/column-env-pickles    #2652      +/-   ##
===========================================================
- Coverage                    72.62%   72.57%   -0.06%     
===========================================================
  Files                          246      246              
  Lines                        58070    58105      +35     
===========================================================
- Hits                         42175    42171       -4     
- Misses                       15895    15934      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from o1vm/column-env-pickles to master October 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants