Poly-commitment/IPA: additional tests regarding expected nb chunks #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/poly-commitment-ipa-additional-tests-regresion
branch
from
262d83a
to
aaaec41
Compare
elems has been renamed in chunks previously, to map the actual meaning of the field of the structure
And also, clarify the current number of chunks returned when the polynomial is of degree higher than the number of chunks requested.
dannywillems
force-pushed
the
dw/poly-commitment-ipa-additional-tests-regresion
branch
from
aedddb0
to
3f8b4b2
Compare
dannywillems
force-pushed
the
dw/poly-commitment-ipa-additional-tests-regresion
branch
from
3f8b4b2
to
51b51c7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dw/fixing-master #2668 +/- ##
===================================================
Coverage ? 72.75%
===================================================
Files ? 245
Lines ? 58037
Branches ? 0
===================================================
Hits ? 42222
Misses ? 15815
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Moving the regression test regarding the number of expected chunks into this PBT module. Transforming it into a PBT helps testing the output with the different PCS available in the library.
dannywillems
force-pushed
the
dw/poly-commitment-ipa-additional-tests-regresion
branch
from
51b51c7
to
9db8c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the prover for o1vm/pickles, I was wondering the number of chunks
commit_non_hidingwas supposed to return in different cases, in particular when the polynomial has a degree higher than the number of chunks requested. This test clarifies it.I hope it doesn't duplicate another test - I didn't look for.
As @querolita is (was?) working on chunking, cc'ing her as she might be interested in.