Poly-commitment/KZG: add tests regarding exp nb of chunks #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the regression test regarding the number of expected chunks into this PBT module. Transforming it into a PBT helps testing the output with the different PCS available in the library.
And include additional documentation for the method. KZG won't be used in production in the near future, and there is no plan for now. Therefore, it seems reasonable to have these changes, with the warning. Note that we should get rid of create_trusted_setup in IPA::SRS, and stop relying on IPA::SRS to define the KZG SRS. It was initially introduced to avoid to reimplement all methods and have something quick for testing.
dannywillems
force-pushed
the
dw/poly-commitment-kzg-regression-tests
branch
from
4efe8eb
to
57634f3
Compare
dannywillems
force-pushed
the
dw/poly-commitment-ipa-additional-tests-regresion
branch
from
51b51c7
to
9db8c60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages