add fixes to the nextjs project for snarkyjs + typescript #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymekuria
requested changes
Oct 27, 2022
ymekuria
approved these changes
Oct 27, 2022
| webpack(config) { | ||
| config.resolve.alias = { | ||
| ...config.resolve.alias, | ||
| snarkyjs: require('path').resolve('./node_modules/snarkyjs'), |
There was a problem hiding this comment.
I'm curious why this is required
There was a problem hiding this comment.
This ensures that the smart contract's snarkyjs and the ui's snarkyjs are the same - otherwise they get imported multiple times. See here for more, in the context of fixing this for duplicate instances of react
There was a problem hiding this comment.
Peer dependancies appeared to fix this issue for contracts imported via npm but not via npm link.
There was a problem hiding this comment.
thanks @es92 this link is a nice resource! another potential trick with npm link is mentioned here (at the bottom): https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react
jasongitmail
suggested changes
Oct 27, 2022
ymekuria
pushed a commit
that referenced
this pull request
Oct 28, 2022
* add fixes to the nextjs project for snarkyjs + typescript * disable react strict mode in nextjs to prevent double loading useEffects * fix some thigns per comments * add ts-watch command to package.json * update script per comments Co-authored-by: Evan Shapiro <[email protected]>
ymekuria
added a commit
that referenced
this pull request
Nov 3, 2022
* feat: add snarkyjs resolve alias nextconfig * feat: read ui current index file * feat: add index file extension from user selection * feat: add ui index template file * add ui newindex template * feat: import contract in template * feat: add snarkyjs to ui index * feat: add contract to local ui state * refactor: remove webpack config * feat: add SnarkyJS to the ui project package.json dependencies * fix: use path.join when updating package.json * fix: use path.join when updating package.json in 2nd place * add fixes to the nextjs project for snarkyjs + typescript (#287) * add fixes to the nextjs project for snarkyjs + typescript * disable react strict mode in nextjs to prevent double loading useEffects * fix some thigns per comments * add ts-watch command to package.json * update script per comments Co-authored-by: Evan Shapiro <[email protected]> * fix: add head import to index template * feat: build template contract to include in ui scaffold * update: invoke import async function * feat: create a contract instance in template * refactor: add commont for strict mode nextjs config option * refactor: add jsx extension to next index file * refactor: rename next index file * fix: remove redundant code * refactor: remove local state and update comments in ui template * feat: add snarkyjs resolve alias nextconfig * feat: read ui current index file * feat: add index file extension from user selection * feat: import contract in template * refactor: remove webpack config * refactor: add custom index to scaffold before ghp config * fix: remove duplicate code * update: change template zkapp address * update: change deployed example contract public key * feat: show console message to add a zkapp public key * feat: change emtpy zkapp address error message * fix: NextJs config snarkyjs require path for Windows Co-authored-by: Jason <[email protected]> Co-authored-by: Evan <[email protected]> Co-authored-by: Evan Shapiro <[email protected]> Co-authored-by: Martin Minkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.