Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sudoku example test errors #312

Closed
wants to merge 1 commit into from

Conversation

MeerKatDev
Copy link

@MeerKatDev MeerKatDev commented Nov 20, 2022

Minimal changes to make tests for sudoku work, as in issue #311

@MeerKatDev
Copy link
Author

I wonder if instead of initialize... there should be

  @method update(sudokuInstance: Sudoku) {

to manually initialize the sudoku hash.

@mitschabaude
Copy link
Contributor

I actually want to make it work with init(), but I think it'll need a change to the CLI's deploy logic

@MeerKatDev
Copy link
Author

but init() does not take arguments, how do you pass the hash() from sudokuInstance ?

@mitschabaude
Copy link
Contributor

yeah @MeerKatDev I just realized this as well. will go with update() as you suggested :D

@mitschabaude
Copy link
Contributor

thanks for making this PR and highlighting what needs to be fixed! I ended up inlcuding this as part a larger PR (#315), so closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants