Show desired block explorer urls #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymekuria
requested review from
mitschabaude and
jasongitmail
and removed request for
mitschabaude
jasongitmail
reviewed
Feb 1, 2023
jasongitmail
reviewed
Feb 1, 2023
|
Left comments, but looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #357
This PR displays the developers desired blockchain explorer URL after sending a deploy transaction.
Approach
The desired blockchain explorer name is parsed from the
Mina GraphQL API URLthat the developer adds after entering thezk configcommand. A blockchain explorer URL with a transaction hash, is constructed and displayed in thezkapp-cliafter sending a deploy transaction. This can be extended to support Mainnet and future blockchain explorers.The blockchain explorer name is also added to the displayed faucet URL as a query parameter after a developer enters the
zk configcommand and adds a newMina GraphQL API URL. The explorer name query parameter can be used in the faucet to display the desired block explorer transaction URL after an account is funded.Testing
This was tested by generating new projects and deploying them with the two currently available
Mina GraphQL API URLs.