-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add landing page for Svelte UI project [Do not merge until landing pages for all supported frameworks are complete] #385
Conversation
Great job on the PR so far! I just have a few suggestions regarding the button styles that might help improve the overall look:
This can also be applied to the NextJS changes too :D Here's a comparison of the current implementation and the Mina Protocol design for reference: |
Thanks for the suggestions @martin! I was following this design, but I am open to all suggestions: |
That's a good point! Aligning with the overall theme does seem valuable, and I recommend making the changes. However, I'll leave the final decision and prioritization up to you and @jasongitmail. 😄 |
Good catch @MartinMinkov Although we can technically use whatever here, it probably makes sense to try the button hover state from Mina's brand guidelines. The implementation follows the design, but I didn't notice hover styles in the design review and that aspect of the design feels like something we could maybe improve. |
@jasongitmail and @MartinMinkov I changed the hover state to follow the guidelines. This is what it currently looks like. Do you think we should also change the arrow color in the non hover state? Current: Option B: |
Option A looks nicer imo, because it makes the button feel more enabled, whereas option B almost has a disabled feel to it. Requested a full screenshot via DM. But I think I like the black hover. |
Closes #371
A landing page was added to the ui projects created with Svelte. The goal of adding this landing page is to provide users with guidance on next steps after generating a zkApp project with an accompanying ui. This page gives users practical immediate next steps as well as guidance on where to dig deeper.
This PR should be merged when the landing pages for Next and Nuxt are also ready to be merged.