Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page for Svelte UI project [Do not merge until landing pages for all supported frameworks are complete] #385

Merged
merged 46 commits into from
Apr 13, 2023

Conversation

ymekuria
Copy link
Collaborator

@ymekuria ymekuria commented Mar 27, 2023

Closes #371

A landing page was added to the ui projects created with Svelte. The goal of adding this landing page is to provide users with guidance on next steps after generating a zkApp project with an accompanying ui. This page gives users practical immediate next steps as well as guidance on where to dig deeper.

This PR should be merged when the landing pages for Next and Nuxt are also ready to be merged.

@MartinMinkov
Copy link
Contributor

Great job on the PR so far! I just have a few suggestions regarding the button styles that might help improve the overall look:

  1. It seems like the hover background color on the buttons is slightly off. Currently, it has an orange background, but maybe we could adjust it to match the design more closely?
  2. When hovering over the button, it would be nice if the background could transition to the dark styles used in Mina Protocol instead of staying white. This way, it'll be more consistent with the overall theme.
  3. I noticed that the arrow icons move a bit on hover. Perhaps we could keep them stationary to maintain a cleaner appearance?

This can also be applied to the NextJS changes too :D

Here's a comparison of the current implementation and the Mina Protocol design for reference:

Current:
image
MinaProtocol:
image

@ymekuria
Copy link
Collaborator Author

ymekuria commented Mar 27, 2023

  1. It seems like the hover background color on the buttons is slightly off. Currently, it has an orange background, but maybe we could adjust it to match the design more closely?
  2. When hovering over the button, it would be nice if the background could transition to the dark styles used in Mina Protocol instead of staying white. This way, it'll be more consistent with the overall theme.
  3. I noticed that the arrow icons move a bit on hover. Perhaps we could keep them stationary to maintain a cleaner appearance?

This can also be applied to the NextJS changes too :D

Here's a comparison of the current implementation and the Mina Protocol design for reference:

Current: image MinaProtocol: image

Thanks for the suggestions @martin! I was following this design, but I am open to all suggestions:

landing-design

@MartinMinkov
Copy link
Contributor

Thanks for the suggestions @martin! I was following this design, but I am open to all suggestions:

That's a good point! Aligning with the overall theme does seem valuable, and I recommend making the changes. However, I'll leave the final decision and prioritization up to you and @jasongitmail. 😄

@jasongitmail
Copy link
Contributor

jasongitmail commented Mar 28, 2023

Good catch @MartinMinkov

Although we can technically use whatever here, it probably makes sense to try the button hover state from Mina's brand guidelines. The implementation follows the design, but I didn't notice hover styles in the design review and that aspect of the design feels like something we could maybe improve.
@ymekuria I'll send you a link to Mina's brand guidelines, but Martin's doc's button design on the homepage probably have the best example to try a hover state like it:

Screen Shot 2023-03-28

@ymekuria
Copy link
Collaborator Author

Although we can technically use whatever here, it probably makes sense to try the button hover state from Mina's brand guidelines.

@jasongitmail and @MartinMinkov I changed the hover state to follow the guidelines. This is what it currently looks like.

hover-btn

Do you think we should also change the arrow color in the non hover state?

Current:

non-hover-current

Option B:

non-hover-option-b

@jasongitmail
Copy link
Contributor

Option A looks nicer imo, because it makes the button feel more enabled, whereas option B almost has a disabled feel to it.

Requested a full screenshot via DM. But I think I like the black hover.

@ymekuria ymekuria merged commit 220db7e into main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create landing page for UI framework: Svelte
4 participants