Update Github Pages Deploy Flow #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for the Next.js app built files This property is used to specify the output directory for the Next.js app. By adding this property, we can configure the app to export the built files to a specific directory, which can be useful for deployment purposes.
MartinMinkov
approved these changes
Dec 11, 2023
shimkiv
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Github Pages deploy flow configuration to be compatible with the current version of
NextJS. Previously, an error occurred when a user rannpm run deployto deploy a UI project to Github Pages which blocked all users from deploying a UI with this command.This occurred because the command in the
zkApp-CLIutilizesNext exportwhich has been deprecated and replaced with additional configuration innext.config.jsfile. The necessary configuration is now added when a user selects the option to deploy to Github Pages in the UI project generation flow.Addresses #533
Testing
The improvements introduced in this PR have been by tested by generating and deploying UI projects with the
zkapp-CLIand running the full e2e testing suite.