Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address the 'zk system' issue on Windows. #612

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Address the 'zk system' issue on Windows. #612

merged 4 commits into from
Mar 27, 2024

Conversation

shimkiv
Copy link
Member

@shimkiv shimkiv commented Mar 27, 2024

Closes #66


This is odd because envinfo issue still exists (when it shows correct data when executed in CLI but fails to find global packages on Windows while invoked via API) despite Windows fixed delivered.
Fixing it using the npm invocation.

@shimkiv shimkiv added the bug Something isn't working label Mar 27, 2024
@shimkiv shimkiv requested a review from ymekuria March 27, 2024 18:40
@shimkiv shimkiv self-assigned this Mar 27, 2024
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this issue @shimkiv! Can you add this fix to the unreleased Changelog?

@shimkiv shimkiv requested a review from ymekuria March 27, 2024 19:57
Copy link
Collaborator

@ymekuria ymekuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a minor suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Yoni Mekuria <[email protected]>
@shimkiv shimkiv merged commit 1f2e2dd into main Mar 27, 2024
12 checks passed
@shimkiv shimkiv deleted the fix/zk-sys-windows branch March 27, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] zk system command does not report zkapp-cli version
2 participants