Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onefetch counts Merge Commits #131

Closed
igroeg opened this issue Oct 29, 2019 · 2 comments · Fixed by #141
Closed

Onefetch counts Merge Commits #131

igroeg opened this issue Oct 29, 2019 · 2 comments · Fixed by #141
Labels
enhancement New feature or request

Comments

@igroeg
Copy link

igroeg commented Oct 29, 2019

Think that it's not ok to count merge commits since they are with no value at all and it makes wrong statistics.
@spenserblack
Copy link
Collaborator

spenserblack commented Oct 29, 2019 •
edited
Loading

Should be simple; there's a --no-merges flag for git rev-list that we can use.
But do merge commits really have no value? Some of them can have changed, or even new code.

@o2sh
Copy link
Owner

o2sh commented Oct 29, 2019

I think we should keep the default behaviour as it is and add a flag that would enable --no-merges on get_commits and get_authors

spenserblack added a commit that referenced this issue Oct 31, 2019
@spenserblack
Add --no-merges flag for total commit count
efe9d70 
Addresses #131
@spenserblack spenserblack added the enhancement New feature or request label Oct 31, 2019
spenserblack added a commit that referenced this issue Oct 31, 2019
@spenserblack
Prevent merge author count on --no-merges
5672098 
Addresses #131
@spenserblack spenserblack mentioned this issue Oct 31, 2019
Merged
@o2sh o2sh closed this as completed in #141 Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/no merges o2sh/onefetch
3 participants
@igroeg @spenserblack @o2sh