Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused shebangs from repo test fixture scripts #1375

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

musicinmybrain
Copy link
Contributor

These are not really doing any harm, but they are not doing any good either, and are perhaps slightly misleading:

An alternative would be to chmod a+x tests/fixtures/*.sh so that the shebang lines can be useful – and are used, if I read the gix-testtools code correctly.

Copy link
Collaborator

@spenserblack spenserblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides running the script, shebangs can be useful as hints for language detection (editors, GitHub stats). But it shouldn't matter since they all have .sh extensions.

@o2sh o2sh merged commit 54678fe into o2sh:main Jul 22, 2024
10 checks passed
@o2sh o2sh added the chore label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants