Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a newer version of askalono so ISC is detected #152

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

ebroto
Copy link
Contributor

@ebroto ebroto commented Nov 6, 2019

It's been some time without a formal release of askalono. Latest is 0.3.0 (Sep 27, 2018), but some changes have been made to the master branch. In order to support ISC, we have to use a newer version which sadly is not available from crates.io.

In addition I've added some code to remove duplicates if multiple files refer to exactly the same license.

Fixes #123

Also:
 * Remove unused build-dependency as we don't generate the cache anymore at
   build time
 * Adapt license module to the new askalono API
 * Remove duplicates when multiple files with the same license are used
@ebroto
Copy link
Contributor Author

ebroto commented Nov 6, 2019

BTW license cache had to be updated because the format has changed. In order to avoid having to maintain the branch dynamic-license-cache, I would suggest using askalono-cli to generate it when necessary.

@o2sh
Copy link
Owner

o2sh commented Nov 6, 2019

Yes, it's indeed quite unfortunate they didn't release a new version for more than a year especially if they fixed bugs since then...

would suggest using askalono-cli to generate it when necessary.

It would be indeed easier to build a cache via askalono-cli

Thanks a lot for your fix/refacto @ebroto

@o2sh o2sh merged commit 575b3ed into o2sh:master Nov 6, 2019
o2sh added a commit that referenced this pull request Nov 6, 2019
@o2sh
Copy link
Owner

o2sh commented Nov 6, 2019

Well, turns out I can't cargo publish with an un-released dependancy...

image

@ebroto
Copy link
Contributor Author

ebroto commented Nov 6, 2019

Damn, I was not aware of this limitation!

I've opened an issue in jpeddicord/askalono#47 and it seems we will have a new version soon 🎉

@jpeddicord
Copy link

Sorry for the huuuuge delta between releases -- 0.4.0 is up now, and I'm going to try to pay attention to making smaller, faster releases.

0.4.0 has some minor breaking changes that include dropping Results where unnecessary and removing a deprecated field. Shouldn't be anything difficult to update to, but I'm happy to help if you need it.

@ebroto ebroto deleted the bugfix/isc-license-not-recognised branch November 7, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISC license not recognized
3 participants