Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump colored from 1.8.0 to 2.0.0 #193

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 24, 2020

Bumps colored from 1.8.0 to 2.0.0.

Changelog

Sourced from colored's changelog.

2.0.0 (July 14, 2020)

  • Add support for true colours.
  • Alter Color interface to return Cow<'static, str>

1.9.3 (February 24, 2020)

  • Fix compilation regression for 1.34.0. Thanks @jlevon for reporting.

1.9.2 (January 11, 2020)

  • Exposed ColoredString data through methods for purposes of interrogating the applied colours.
  • Increased documentation.

1.9.1 (December 31, 2019)

  • Remove deprecated try! macro in codebase
  • Reduce allocations in ColoredString impl (PR#65)
  • Added "purple" as match in impl FromStr for Color (PR#71)

1.9.0 (November 11, 2019)

  • [POSSIBLE_BREAKING CHANGE]: Replace winconsole with winapi:
    • Changes set_virtual_terminal function signature.
  • Update dependencies
  • Add Dockerfile
  • Respect tty discovery for CLICOLOR
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @spenserblack.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 24, 2020
@dependabot dependabot bot force-pushed the dependabot/cargo/colored-2.0.0 branch 4 times, most recently from e4dcbf1 to 160e3ad Compare August 24, 2020 14:15
@dependabot dependabot bot force-pushed the dependabot/cargo/colored-2.0.0 branch from 160e3ad to becb948 Compare August 24, 2020 14:19
@spenserblack spenserblack force-pushed the dependabot/cargo/colored-2.0.0 branch 2 times, most recently from 447e524 to 63098a7 Compare August 24, 2020 15:11
@spenserblack
Copy link
Collaborator

spenserblack commented Aug 24, 2020

@o2sh Are there any collaborators/contributors that use Windows? Looks like colored @ 2.0.0 has better detection of whether or not to enable colors (enough to fail the CI without forcing colors 😆), so we may be able to get rid of the ansi_term dependency and the conditional compilation that we added to fix #86.

@spenserblack spenserblack requested a review from o2sh August 24, 2020 15:32
@o2sh
Copy link
Owner

o2sh commented Aug 24, 2020

I'm on windows, I'll try it and report back 👍

@o2sh
Copy link
Owner

o2sh commented Aug 24, 2020

So, after removing that part from src/main.rs

    #[cfg(target_os = "windows")]
    let enabled = ansi_term::enable_ansi_support().is_ok();

    #[cfg(not(target_os = "windows"))]
    let enabled = true;

    if enabled {
        colored::control::set_override(true);
    }

I checked out this branch (dependabot/cargo/colored-2.0.0) compiled and ran onefetch.
Unfortunately, I got the "horrible output" of #86

@spenserblack
Copy link
Collaborator

spenserblack commented Aug 24, 2020

I guess colored still needs more work on Windows support 😿
Anyway, thanks for testing that!

@o2sh
Copy link
Owner

o2sh commented Aug 24, 2020

Yeah, I got my hopes up for a second...maybe it works on some configuration of windows/terminal.

@spenserblack
Copy link
Collaborator

@dependabot merge

@dependabot dependabot bot merged commit 873fc45 into master Aug 24, 2020
@dependabot dependabot bot deleted the dependabot/cargo/colored-2.0.0 branch August 24, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants