-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump colored from 1.8.0 to 2.0.0 #193
Conversation
e4dcbf1
to
160e3ad
Compare
Bumps [colored](https://github.com/mackwic/colored) from 1.8.0 to 2.0.0. - [Release notes](https://github.com/mackwic/colored/releases) - [Changelog](https://github.com/mackwic/colored/blob/master/CHANGELOG.md) - [Commits](colored-rs/colored@v1.8.0...v2.0.0) Signed-off-by: dependabot[bot] <[email protected]>
160e3ad
to
becb948
Compare
447e524
to
63098a7
Compare
63098a7
to
39af779
Compare
@o2sh Are there any collaborators/contributors that use Windows? Looks like colored @ 2.0.0 has better detection of whether or not to enable colors (enough to fail the CI without forcing colors 😆), so we may be able to get rid of the ansi_term dependency and the conditional compilation that we added to fix #86. |
I'm on windows, I'll try it and report back 👍 |
So, after removing that part from src/main.rs
I checked out this branch (dependabot/cargo/colored-2.0.0) compiled and ran onefetch. |
I guess colored still needs more work on Windows support 😿 |
Yeah, I got my hopes up for a second...maybe it works on some configuration of windows/terminal. |
@dependabot merge |
Bumps colored from 1.8.0 to 2.0.0.
Changelog
Sourced from colored's changelog.
Commits
015f2a5
update dependencies (#82)5d828f2
Ver 2 (#81)25f29cc
Avoid unnecessary copies if there is nothing to escape (#80)18b5ff8
Add support for TrueColor (#78)2b94a69
Fix various warnings and issues (#79)07425ea
Fix test failures with --features no-color (#75)5dedbe9
release v1.9.324ba05b
Fix compilation regression for 1.347e75fda
release v1.9.2c7e21ec
Expose colored string (#73)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @spenserblack.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)