Add flag to disable/enable boldness #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are some merge conflicts from some recent work on master. I should be able to work on addressing these later today. |
Merged
|
I fixed the merge conflicts but I still need to make adjustments to existing tests |
o2sh
requested review from
andymac-2 and
spenserblack
and removed request for
andymac-2 and
spenserblack
|
Just noticed I have a few more conflicts to resolve! I can work on resolving those tomorrow. |
|
Sorry for the late review, just realized I didn't submit it for 2 days 🤦♂️ |
|
The latest commits include some adjustments based on the new file organization as well as changing the command line option from |
spenserblack
requested changes
Oct 23, 2019
|
Just pushed some changes that address the most recent code review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #95
This is my first time using Rust so let me know if there is anything that I'm doing that isn't following best practices. 🙂