Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minidnf: Clean up displayed texts #15

Merged

Conversation

didib
Copy link
Member

@didib didib commented Feb 15, 2022

Add a few missing ones.

Change a bit to partially match dnf.

Log details for unknown actions.

Change-Id: Ib445c49ad216d480717aa329bf0bb069069970b6
Bug-Url: https://bugzilla.redhat.com/2047260
Signed-off-by: Yedidyah Bar David [email protected]

Add a few missing ones.

Change a bit to partially match dnf.

Log details for unknown actions.

Change-Id: Ib445c49ad216d480717aa329bf0bb069069970b6
Bug-Url: https://bugzilla.redhat.com/2047260
Signed-off-by: Yedidyah Bar David <[email protected]>
@didib didib force-pushed the minidnf-clean-up-displayed-texts branch from 83822a0 to 2633848 Compare February 15, 2022 14:33
@didib
Copy link
Member Author

didib commented Feb 15, 2022

Verified locally manually, and also grepped for 'unknown' in the check-patch logs - in current patch's run, had none, in previous run had:

[ybardavi@ybardavi otopi_logs]$ grep -iw unknown /
otopi-20220208-144512-packager-install-update-testpackage1-undo/otopi-output-packager-install-update-testpackage1-undo.log:[ INFO ] DNF Unknown: testpackage1-1.0.0-1.el8.noarch
otopi-20220208-144512-packager-install-update-testpackage1-undo/otopi-output-packager-install-update-testpackage1-undo.log:[ INFO ] DNF Unknown: testpackage1-1.0.1-1.el8.noarch
otopi-20220208-144512-packager-install-update-testpackage1-undo/otopi-packager-install-update-testpackage1-undo-20220208144512-ewu53j.log:2022-02-08 14:45:20,139+0000 INFO otopi.plugins.otopi.packagers.dnfpackager dnfpackager.info:79 DNF Unknown: testpackage1-1.0.0-1.el8.noarch
otopi-20220208-144512-packager-install-update-testpackage1-undo/otopi-packager-install-update-testpackage1-undo-20220208144512-ewu53j.log:2022-02-08 14:45:22,076+0000 INFO otopi.plugins.otopi.packagers.dnfpackager dnfpackager.info:79 DNF Unknown: testpackage1-1.0.1-1.el8.noarch
otopi-20220208-144533-packager-install-update-testpackage1-do/otopi-output-packager-install-update-testpackage1-do.log:[ INFO ] DNF Unknown: testpackage1-1.0.0-1.el8.noarch
otopi-20220208-144533-packager-install-update-testpackage1-do/otopi-packager-install-update-testpackage1-do-20220208144533-a4didt.log:2022-02-08 14:45:40,697+0000 INFO otopi.plugins.otopi.packagers.dnfpackager dnfpackager.info:79 DNF Unknown: testpackage1-1.0.0-1.el8.noarch

I also verified locally the 'Unknown action' logs (well, at least one of them, not sure how to enforce all of them) by commenting out a few translations, so that they'll be missing:

[root@didi-centos8-engine tmp]# grep -i 'unknown action' otopi-202202151*
otopi-20220215161628-kx427g.log:2022-02-15 16:16:38,605+0200 DEBUG otopi.plugins.otopi.packagers.dnfpackager dnfpackager.verbose:75 DNF filelog: Unknown action 6, package sysfsutils-2.1.0-25.el8.x86_64
otopi-20220215161628-kx427g.log:2022-02-15 16:16:38,639+0200 DEBUG otopi.plugins.otopi.packagers.dnfpackager dnfpackager.verbose:75 DNF filelog: Unknown action 7, package sysfsutils-2.1.0-24.el8.x86_64
otopi-20220215161700-y3zmdw.log:2022-02-15 16:17:10,023+0200 DEBUG otopi.plugins.otopi.packagers.dnfpackager dnfpackager.verbose:75 DNF filelog: Unknown action 3, package sysfsutils-2.1.0-25.el8.x86_64

The numbers (6, 7, 3) are from the (C++) TransactionItemAction enum class here:

https://github.com/rpm-software-management/libdnf/blob/dnf-4-master/libdnf/transaction/Types.hpp#L45

Copy link
Member

@sandrobonazzola sandrobonazzola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandrobonazzola sandrobonazzola merged commit 297e2ab into oVirt:master Feb 15, 2022
@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.0 milestone Feb 15, 2022
@didib didib deleted the minidnf-clean-up-displayed-texts branch February 15, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants