Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection close at the end of inventory sync #122

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

kedark3
Copy link
Contributor

@kedark3 kedark3 commented Sep 16, 2020

Problem

During our usage of Ansible Tower and Inventory Sync operations against RHV we saw following:

1- We do inv sync frequently
2- Our RHV had sessions timeout after an hour
3- so it held onto all connections in the db and JVM (java )
4- connections pile up

This connection piling up is not good for environment as it uses resources unnecessarily.

It is important we close out connection at the end.

Solution

Close the connection at the end of sync.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mnecas
Copy link
Member

mnecas commented Sep 16, 2020

ci test please

@oVirt oVirt deleted a comment from kedark3 Sep 16, 2020
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 69c3b47 into oVirt:master Sep 16, 2020
@kedark3
Copy link
Contributor Author

kedark3 commented Sep 16, 2020

@mnecas thanks for quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants