Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set hosted-engine VM with custom bios type (Q35+SeaBIOS) #129

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

ahadas
Copy link
Member

@ahadas ahadas commented Sep 22, 2020

To prevent its bios type from changing when the cluster's bios type changes

Bug-Url: https://bugzilla.redhat.com/1871694
Signed-off-by: Arik Hadas [email protected]

@ahadas
Copy link
Member Author

ahadas commented Sep 22, 2020

ci test

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arachmani
Copy link
Member

@ahadas Please add Bug-Url in the commit message.

To prevent its bios type from changing when the cluster's bios type changes

Bug-Url: https://bugzilla.redhat.com/1871694
Signed-off-by: Arik Hadas <[email protected]>
@ahadas
Copy link
Member Author

ahadas commented Sep 23, 2020

@arachmani done
also passed OST

@ahadas
Copy link
Member Author

ahadas commented Sep 23, 2020

also passed OST

actually, not sure the he-basic-suite-master job tests it with the specified ansible-collection..
@mnecas what's the right way to verify this PR using an automation job?

@arachmani
Copy link
Member

In order to use ansible-collection in the he-basic-suite-master job, we need https://gerrit.ovirt.org/#/c/111385/ .

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit fcb643f into oVirt:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants