roles: hosted_engine_setup: Use zcat instead of gzip #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use zcat instead of gzip to check the size of the appliance gzip reports incorrect uncompressed sizes for large files Bug-Url: https://bugzilla.redhat.com/1821425 Signed-off-by: Asaf Rachmani <[email protected]>
|
Even this change does not change the logic I would want it to have it recorded in changelog so could you please add the fragment? |
Signed-off-by: Asaf Rachmani <[email protected]>
|
@eslutsky, can you please review? |
eslutsky
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use zcat instead of gzip to check the size of the appliance
gzip reports incorrect uncompressed sizes for large files
Bug-Url: https://bugzilla.redhat.com/1821425
Signed-off-by: Asaf Rachmani [email protected]