Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Basic Auth for REST API calls #131

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Force Basic Auth for REST API calls #131

merged 2 commits into from
Sep 25, 2020

Conversation

KlettIT
Copy link
Contributor

@KlettIT KlettIT commented Sep 24, 2020

Force basic authentication when request server CPU list and emulated machine list via REST API. This is needed cause when restoring an engine from backup, where aaa-authentication was configured, the task will fail cause the REST API call will try to negotiate.

Force basic authentication when request server CPU list and emulated machine list via REST API. This is needed cause when restoring an engine from backup, where aaa-authentication was configured, the task will fail cause the REST API call will try to negotiate.
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mnecas
Copy link
Member

mnecas commented Sep 24, 2020

ci test please

@mnecas
Copy link
Member

mnecas commented Sep 24, 2020

@KlettIT please add fragment where you describe the change. You can inspire yourself from changelogs/fragments/.
@arachmani could you please review?

@KlettIT
Copy link
Contributor Author

KlettIT commented Sep 24, 2020

@mnecas Done, hope it fits.

@mwperina
Copy link
Member

ci add to whitelist

@mwperina
Copy link
Member

mwperina commented Sep 24, 2020

@didib @sandrobonazzola

@didib
Copy link
Member

didib commented Sep 24, 2020

Looks good to me. Thanks!

Seems worthy of a "Bug-Url:", no? Do we have a bug open?

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas
Copy link
Member

mnecas commented Sep 24, 2020

Looks good to me. Thanks!

Seems worthy of a "Bug-Url:", no? Do we have a bug open?

I'm not aware of any opened bug on this.

@sandrobonazzola
Copy link
Member

@mnecas, @mwperina I think you can merge now.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mwperina mwperina merged commit c0a1e73 into oVirt:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants