Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bios Type option #15

Merged
merged 4 commits into from
Mar 31, 2020
Merged

Add Bios Type option #15

merged 4 commits into from
Mar 31, 2020

Conversation

DarinJ
Copy link
Contributor

@DarinJ DarinJ commented Mar 26, 2020

The option for bios_type was missing from Ansible even though it was in the Ovirt SDK, this creates issues when one wishes to make VMs that use UFEI or secure boot.

While bios_type and boot_menu are both subfields of the bios object, we elected to keep the flat structure as it's intuitive and preserves backwards compatibility.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

…in the Ovirt SDK, this creates issues when one wishes to make VMs that use UFEI.

While bios_type and boot_menu are both subfields of the bios object, we elected to keep the flat structure as it's intuitive and preserves backwards compatibility.
@mnecas
Copy link
Member

mnecas commented Mar 31, 2020

ci test please

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants