roles: hosted_engine_setup: Do not reboot the host during deploy #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
We recently changed the host-deploy process to reboot the host after installation. We need to revert that for hosted-engine deploy, as this reboots the host we deploy on, thus killing the deployment.
didib
force-pushed
the
do-not-reboot-host-he-deploy
branch
from
b8c24c0
to
952c232
Compare
mnecas
reviewed
Feb 10, 2021
There was a problem hiding this comment.
I'll check out that CI issue, looks like a new version of yamlint.
I don't mind the change, but not sure if it's necessary. That's a question for @arachmani
There was an issue with doing something on the host right after installation but it was fixed in the engine by https://gerrit.ovirt.org/c/ovirt-engine/+/113388
mwperina
approved these changes
Feb 10, 2021
|
And let's take a look at CI separately |
arachmani
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed the host-deploy process to reboot the host after
installation. We need to revert that for hosted-engine deploy, as this
reboots the host we deploy on, thus killing the deployment.