role: hosted_engine_setup: Use ovirt_host module #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `ovirt_host` module to discover iSCSI instead of using REST API. Requires a change in ovirt-hosted-engine-setup and cockpit-ovirt Bug-Url: https://bugzilla.redhat.com/1922748 Signed-off-by: Asaf Rachmani <[email protected]>
|
Requires the following changes: |
|
Verified using |
gerrit-ovirt-org
pushed a commit
to oVirt/ovirt-hosted-engine-setup
that referenced
this pull request
May 27, 2021
The change [1] in hosted_engine_setup role impacts the structure of the otopi_iscsi_targets variable [1] oVirt/ovirt-ansible-collection#275 Bug-Url: https://bugzilla.redhat.com/1922748 Signed-off-by: Asaf Rachmani <[email protected]> Change-Id: Ieaa7a787e2815ed26e94c33d3109ea3ad176065e
kobihk
reviewed
May 27, 2021
Comment on lines
+28
to
+29
| username: "{{ he_iscsi_discover_username }}" | ||
| password: "{{ he_iscsi_discover_password }}" |
There was a problem hiding this comment.
if these parameters are null maybe it will be better to omit them?
| Content-Type: application/json | ||
| Accept: application/json | ||
| Authorization: "Basic {{ ('admin@internal' + ':' + he_admin_password ) | b64encode }}" | ||
| - name: iSCSI discover |
There was a problem hiding this comment.
with this change, I think you need to remove lines # 3-11
There was a problem hiding this comment.
Right, I'll do remove these lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
ovirt_hostmodule to discover iSCSIinstead of using REST API.
Requires a change in ovirt-hosted-engine-setup and cockpit-ovirt
Bug-Url: https://bugzilla.redhat.com/1922748
Signed-off-by: Asaf Rachmani [email protected]