Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on safe_eval being able to do math/concat #307

Merged
merged 3 commits into from
Jun 25, 2021

Conversation

sivel
Copy link
Contributor

@sivel sivel commented Jun 22, 2021

Don't rely on safe_eval being able to do math/concat. This functionality will be removed in ansible-core 2.12, and has never worked with jinja2 native which we are working toward making the default in 2.12.

See ansible/ansible#75068

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mnecas
Copy link
Member

mnecas commented Jun 24, 2021

ci add to whitelist

@mnecas mnecas requested a review from barpavel June 24, 2021 08:41
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add changelog

@sivel
Copy link
Contributor Author

sivel commented Jun 24, 2021

Done. Sorry about that. We don't require changelog fragments in ansible/ansible for test only changes, didn't realize collections did.

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mnecas mnecas merged commit a977dd5 into oVirt:master Jun 25, 2021
vjuranek pushed a commit to vjuranek/ovirt-ansible-collection that referenced this pull request Jul 28, 2021
* Don't rely on safe_eval being able to do math/concat

* add clog frag

* yamllint fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants