Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt_permission: fix group search that has space in it's name #318

Merged
merged 2 commits into from
Jul 14, 2021
Merged

ovirt_permission: fix group search that has space in it's name #318

merged 2 commits into from
Jul 14, 2021

Conversation

nijinashok
Copy link
Contributor

@nijinashok nijinashok commented Jul 14, 2021

Currently if we try to add a group with space to any object, it will fails with error "Group was not found". This fixes the same.

RHBZ: https://bugzilla.redhat.com/1982058

    Currently if we try to add a group with space to any object, it
    will fails with error "Group was not found". This fixes the same.

    RHBZ: https://bugzilla.redhat.com/1982058
@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mnecas
Copy link
Member

mnecas commented Jul 14, 2021

ci test please

Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 16385e7 into oVirt:master Jul 14, 2021
vjuranek pushed a commit to vjuranek/ovirt-ansible-collection that referenced this pull request Jul 28, 2021
…#318)

* ovirt_permission: fix group search that has space in it's name

    Currently if we try to add a group with space to any object, it
    will fails with error "Group was not found". This fixes the same.

    RHBZ: https://bugzilla.redhat.com/1982058

* Create 318-ovirt_permission-fix-group-search-that-has-space.yml

Co-authored-by: Martin Nečas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants