Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovirt_vm: Add documentation for custom_script under sysprep #52

Merged
merged 1 commit into from
Jun 8, 2020
Merged

ovirt_vm: Add documentation for custom_script under sysprep #52

merged 1 commit into from
Jun 8, 2020

Conversation

nijinashok
Copy link
Contributor

The custom_script already works for sysprep. Add the documentation
for the same.

@ovirt-infra
Copy link

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow ovirt dynamic plugin improvements #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

@mwperina
Copy link
Member

mwperina commented Jun 4, 2020

ci add to whitelist

mwperina
mwperina approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@mwperina mwperina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

mnecas
mnecas requested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
Could you please also add it to the ovirt_template?

plugins/modules/ovirt_vm.py Outdated Show resolved Hide resolved
@nijinashok
ovirt_vm,ovirt_template: Add documentation for custom_script under sy…
b31e7b0 
…sprep

The custom_script already works for sysprep. Add the documentation
for the same.
mnecas
mnecas approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnecas mnecas merged commit 6f4b752 into oVirt:master Jun 8, 2020
@mnecas mnecas mentioned this pull request Jun 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwperina mwperina mwperina approved these changes

@mnecas mnecas mnecas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nijinashok @ovirt-infra @mwperina @mnecas