fix grouping sets number validate (#108)

oap-project · Jan 5, 2023 · 277e0bf · 277e0bf
1 parent 68d0299
commit 277e0bf
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/velox/substrait/SubstraitToVeloxPlanValidator.cpp b/velox/substrait/SubstraitToVeloxPlanValidator.cpp
@@ -14,6 +14,7 @@
  * limitations under the License.
  */
 
+#include <glog/logging.h>
 #include "velox/substrait/SubstraitToVeloxPlanValidator.h"
 #include "TypeUtils.h"
 #include "velox/expression/SignatureBinder.h"
@@ -181,6 +182,11 @@ bool SubstraitToVeloxPlanValidator::validate(
       }
     }
   }
+  // GroupIdNode constructor check
+  if (sExpand.groupings_size() <= 2) {
+    LOG(INFO) << "GroupIdNode requires two or more grouping sets.";
+    return false;
+  }
 
   return true;
 }