Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables getting value from date variant with integer type #113

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Jan 9, 2023

Fixed the data type check when getting value from a date variant with integer type.

@rui-mo
Copy link
Collaborator Author

rui-mo commented Jan 9, 2023

@PHILO-HE Would you like to take a review? Thanks.

Copy link
Collaborator

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rui-mo rui-mo merged commit 880fd31 into oap-project:main Jan 9, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Feb 27, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Mar 6, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Mar 27, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Mar 29, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Mar 29, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Apr 14, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Apr 17, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Apr 19, 2023
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this pull request Apr 20, 2023
marin-ma added a commit to marin-ma/velox-oap that referenced this pull request Dec 15, 2023
…project#113)

* push down filter to scan options

* Update cpp/gazelle-cpp/compute/substrait_arrow.cc

Co-authored-by: david <[email protected]>

* lint

* update function namespace

Co-authored-by: david <[email protected]>
@rui-mo rui-mo deleted the variant branch February 20, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants