-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the window support #61
Conversation
eb2944b
to
658199a
Compare
29fda23
to
47017d2
Compare
eb8726a
to
29242f2
Compare
29242f2
to
b8dd396
Compare
return std::make_unique<RankFunction<TRank, TResult>>(resultType); | ||
}); | ||
} | ||
|
||
void registerRank(const std::string& name) { | ||
registerRankInternal<RankType::kRank, int64_t>(name, "bigint"); | ||
registerRankInternal<RankType::kRank, int32_t>(name, "integer"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change used to align Rank with Spark? In the long term, maybe we could consider to implement aligned Rank under sparksql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Will implement the Rank under sparksql function later.
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
relative pr: Check a fallback case in validation: using literal partition key in window function oap-project#148 Fix might_contain validate fallback and support struct literal oap-project#137 Implement datetime functions in velox/sparksql. oap-project#81 Parse options in SingularOrList correctly oap-project#48 Add SingularOrList support oap-project#45 Support if then in filter oap-project#74 Fix semi join output type and support existence join oap-project#67 Support decimal as partition column oap-project#167 Add the window support oap-project#61 Add expand operator oap-project#65 Support more cases of filter and its pushdown #14
No description provided.