Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode errors when validating files #233

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Apr 3, 2024

Previously undetected because testing was only performed on systems where utf-8 is default.

Previously undetected because testing performed on systems where utf-8
is default.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (2330398) to head (538b7fa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   94.47%   94.48%           
=======================================
  Files          66       66           
  Lines        6174     6178    +4     
=======================================
+ Hits         5833     5837    +4     
  Misses        341      341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpiazza rpiazza merged commit 5ebca8c into oasis-open:master Apr 4, 2024
9 checks passed
@clenk clenk deleted the open-file-unicode branch April 4, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants