Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODATA-1412 - Capabilities vocabulary: Add EntityContainer as annotation target #119

Merged
merged 27 commits into from
Apr 10, 2024

Conversation

GeraldKrause
Copy link
Contributor

@GeraldKrause GeraldKrause commented Apr 16, 2021

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

@@ -203,13 +207,17 @@
],
"@Core.Description": "Restrictions on /$count path suffix and $count=true system query option"
},
"CountRestrictionsType": {
"CommonCountRestrictionsType": {
"$Kind": "ComplexType",
"Countable": {
"$Type": "Edm.Boolean",
"$DefaultValue": true,
"@Core.Description": "Entities can be counted (only valid if targeting an entity set)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@Core.Description": "Entities can be counted (only valid if targeting an entity set)"
"@Core.Description": "Entities can be counted (only valid if targeting a collection)"

@ralfhandl ralfhandl changed the title OData-1412 - Capabilities vocabulary: Add EntityContainer as annotation target ODATA-1412 - Capabilities vocabulary: Add EntityContainer as annotation target Mar 24, 2023
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligned with @ralfhandl and @GeraldKrause

vocabularies/Org.OData.Capabilities.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Capabilities.V1.xml Show resolved Hide resolved
@ralfhandl ralfhandl merged commit fdaaa96 into main Apr 10, 2024
1 check passed
@ralfhandl ralfhandl deleted the ODATA-1412 branch April 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capabilities vocabulary: Add EntityContainer as annotation target
3 participants