Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative search syntax #241

Merged
merged 10 commits into from
May 29, 2024
Merged

Conversation

HeikoTheissen
Copy link
Contributor

No description provided.

@HeikoTheissen HeikoTheissen linked an issue Apr 4, 2024 that may be closed by this pull request
@HeikoTheissen HeikoTheissen changed the title Alternative search Alternative search syntax Apr 4, 2024
@ralfhandl ralfhandl changed the base branch from main to v4.02-release-candidate April 4, 2024 09:50
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change proposal

<Property Name="SearchSyntax" Type="Edm.String" Nullable="true">
<Annotation Term="Core.IsURL" />
<Annotation Term="Core.Description" String="URL of the $search syntax supported by the service if this deviates from the standard syntax [OData-URL, section 5.1.8.1](https://docs.oasis-open.org/odata/odata/v4.02/odata-v4.02-part2-url-conventions.html#SearchExpressions)" />
</Property>
</ComplexType>
<EnumType Name="SearchExpressions" IsFlags="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add

        <Member Name="all" Value="31">
          <Annotation Term="Core.Description" String="Only plain search terms are supported" />
        </Member>

Copy link
Contributor Author

@HeikoTheissen HeikoTheissen Apr 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can, but that does not mean that NOT may be interpreted as a term to be matched. See oasis-tcs/odata-specs#1918 (comment).

@ralfhandl ralfhandl merged commit 1e83dca into v4.02-release-candidate May 29, 2024
1 check passed
@ralfhandl ralfhandl deleted the alternative-search branch May 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow alternate / native search syntax
2 participants