Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast vote flow #18

Merged
merged 10 commits into from
Mar 12, 2024
Merged

Cast vote flow #18

merged 10 commits into from
Mar 12, 2024

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Mar 11, 2024 •
edited
Loading

Solution

Add submit vote flow

  • add generated types from @oasisprotocol/dapp-voting-backend
  • adds testnet .env and empty .env.production file
  • Fetch poll data
  • Submit vote - with edge cases(insufficient balance, error, success)

Resources

https://www.loom.com/share/94556255650c4b5b82701ca66450722d

@lubej lubej force-pushed the ml/smart-contract-fe-integration branch 4 times, most recently from 4cc74d0 to 0bcc58a Compare March 11, 2024 13:42
@lubej lubej changed the title Smart contract integration Cast vote flow Mar 11, 2024
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from ea5b50f to 021c555 Compare March 11, 2024 18:24
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from 021c555 to 1bad10e Compare March 11, 2024 18:26
@lubej lubej marked this pull request as ready for review March 11, 2024 18:32
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch 4 times, most recently from cc67fa8 to 57e0323 Compare March 12, 2024 06:09
@lubej lubej mentioned this pull request Mar 12, 2024
Merged
buberdds
buberdds reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will look at one more file after lunch

frontend/src/providers/ConfigProvider.tsx Outdated Show resolved Hide resolved
frontend/src/providers/EIP1193Provider.tsx Show resolved Hide resolved
frontend/src/providers/Web3Context.ts Show resolved Hide resolved
frontend/.env Show resolved Hide resolved
frontend/.env Show resolved Hide resolved
frontend/src/pages/HomePage/index.tsx Outdated Show resolved Hide resolved
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from 57e0323 to 1c9c0d5 Compare March 12, 2024 12:36
@lubej lubej requested a review from buberdds March 12, 2024 12:50
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from 1c9c0d5 to 55ea970 Compare March 12, 2024 15:25
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch 2 times, most recently from 038d76b to e00fffd Compare March 12, 2024 15:33
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from e00fffd to 44b12f2 Compare March 12, 2024 15:35
@lubej
Add getPoll contract call
8d01b54 
- prepare canVoteOnPoll & vote contract calls
@lubej
Add vote initial flow
a0ec84b
@lubej
Add BE build before FE build in CI
8c7727f 
- FE build depends on @oasisprotocol/dapp-voting-backend
@lubej
Add insufficient balance flow
782c7e5
@lubej lubej force-pushed the ml/smart-contract-fe-integration branch from 44b12f2 to 782c7e5 Compare March 12, 2024 15:39
@lubej lubej merged commit 036f55a into master Mar 12, 2024
2 checks passed
@lubej lubej deleted the ml/smart-contract-fe-integration branch March 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buberdds buberdds buberdds approved these changes

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

@csillag csillag Awaiting requested review from csillag csillag is a code owner

@kaja-osojnik kaja-osojnik Awaiting requested review from kaja-osojnik kaja-osojnik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubej @buberdds