Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error boundaries #48

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Add error boundaries #48

merged 4 commits into from
Mar 19, 2024

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Mar 19, 2024

Description

  • adds ErrorBoundary component, for catching ContextProvider errors;
  • adds RouterErrorBoundary component for catching route and its children errors;

Resources

Screenshot_19-3-2024_162755_localhost

@lubej lubej changed the title Ml/error bundary Add error bundaries Mar 19, 2024
@lubej lubej changed the title Add error bundaries Add error boundaries Mar 19, 2024
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to check if this works.

@lubej
Copy link
Collaborator Author

lubej commented Mar 19, 2024

I'm not sure how to check if this works.

To check ErrorBoundary, throw an error in one of the ContextProviders(Needs to be uncaught of course).
To check RouterErrorBoundary throw an error in one of the components(ConnectedAccount for example)

@lubej lubej merged commit 68831f5 into master Mar 19, 2024
2 checks passed
@lubej lubej deleted the ml/error-bundary branch March 19, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants