This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Migrate the oasis-core ledger integration to this repository #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
force-pushed
the
yawning/feature/crawling-in-my-skin
branch
8 times, most recently
from
a4b77a3
to
413a802
Compare
Yawning
force-pushed
the
yawning/feature/crawling-in-my-skin
branch
from
6e650fd
to
a634ffb
Compare
This work-arounds an issue where wrong a wrong commit is being checked out.
* Improve the common tests * Match the oasis-core test style * Use `testing.T.Logf` * Add more checks for the chunking routine * Refactor the chunk generator * Make a lot of things private * Changed error returns to match oasis-core conventions * Use structured logging * Other misc cleanups The tests under `app_test.go` could also use similar improvements, however I am reluctant to alter test cases I have no way of actually running to completion.
Yawning
force-pushed
the
yawning/feature/crawling-in-my-skin
branch
from
a634ffb
to
b5fc2b3
Compare
tjanez
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
-trimpathwhen buildingoasis-node, I'm not sure if that will make the runtime library's plugin loader mad if we don't set the same options when building the plugin.