github: Reject merge commits in pull requests in ci-lint workflow #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
lukaw3d,
peterjgilbert and
pro-wh
as code owners
|
NOTE: I'll leave this in failed state so the reviewer(s) can see how it works. Before merging, I'll rebase it and remove the XXX commit. |
lukaw3d
reviewed
Aug 27, 2021
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| # Run this step even if the previous one fails so that all linting | ||
| # errors can be seen at once. BLA |
There was a problem hiding this comment.
Yeah, that's in the XXX commit 😀
lukaw3d
approved these changes
Aug 27, 2021
Comment on lines
+49
to
+51
| uses: Morishiri/[email protected] | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
I don't like their error message "1 commit(s) cannot be merged", but it isn't configurable :(
|
opposing this we'll want merging for times when we neither want to rewrite all commits nor want to squash everything into a single commit |
pro-wh
requested changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.